FIX: Double-check dtypes within tests and increase RMSE tolerance #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the tests less brittle so that they don't fail with FSL 6.0. Closes #52.
oesteban
changed the title
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 12 12
Lines 1081 1081
Branches 164 164
=======================================
Hits 1069 1069
Misses 6 6
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the tests less brittle so that they don't fail with FSL 6.0. This doesn't actually address the problems seemingly discovered in FSL 6.0 interpolator (#52), it just raises the bar just enough for tests to pass with FSL 6.0.