Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Final edits to JOSS submission #135

Merged
merged 1 commit into from
Sep 10, 2021
Merged

FIX: Final edits to JOSS submission #135

merged 1 commit into from
Sep 10, 2021

Conversation

oesteban
Copy link
Collaborator

Edits to the submission text following @osorensen's suggestions (openjournals/joss-reviews#3459 (comment)):

  • Add a reference to Figure 1 in the text. Maybe somewhere in the Methods section on page 2?
  • Page 3: Add caption to Figure 1.

Edits to the submission text following @osorensen's suggestions (openjournals/joss-reviews#3459 (comment)):
* Add a reference to Figure 1 in the text. Maybe somewhere in the Methods section on page 2?
* Page 3: Add caption to Figure 1.
@oesteban oesteban requested a review from mgxd September 10, 2021 07:05
@oesteban
Copy link
Collaborator Author

I'm going to merge and see if the changes have the intended effect (not sure the caption will render now, and also unsure the cross-reference is correctly done)

@oesteban oesteban merged commit 31c2abb into master Sep 10, 2021
@oesteban oesteban deleted the oesteban-patch-1 branch September 10, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant