Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Suggested edits to the JOSS submission #121

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Conversation

oesteban
Copy link
Collaborator

Updates the JOSS submission to incorporate the suggestions by @PeerHerholz.

References: openjournals/joss-reviews#3459
Resolves: #119.

Updates the JOSS submission to incorporate the suggestions by @PeerHerholz.

References: openjournals/joss-reviews#3459
Resolves: #119.
@oesteban oesteban requested a review from mgxd July 14, 2021 07:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #121 (0b58b61) into master (0b36f40) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b58b61 differs from pull request most recent head 68679a4. Consider uploading reports for the commit 68679a4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          12       12           
  Lines        1084     1084           
  Branches      138      138           
=======================================
  Hits         1072     1072           
  Misses          6        6           
  Partials        6        6           
Flag Coverage Δ
travis 98.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b36f40...68679a4. Read the comment docs.

@robbisg robbisg mentioned this pull request Jul 14, 2021
@oesteban oesteban requested a review from mgxd July 14, 2021 16:18
@oesteban
Copy link
Collaborator Author

I have added one "audience" paragraph, following JOSS' guidelines.

@mgxd
Copy link
Member

mgxd commented Jul 14, 2021

LGTM, looking a little closer at the requirements and I wonder if it would be good to mention nitransforms has been integrated into fMRIPrep. This is based on the bullet point:

Mention (if applicable) a representative set of past or ongoing research projects using the software and recent scholarly publications enabled by it.

@oesteban
Copy link
Collaborator Author

I think that's sensible, please pr against this branch (or commit directly to it)

@oesteban oesteban merged commit f0e0f7c into master Jul 15, 2021
@oesteban oesteban deleted the oesteban-patch-1 branch July 15, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS review - software paper sections
3 participants