BUG: Reading serialized event requires conversion of dates #3528
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3528 +/- ##
==========================================
- Coverage 63.17% 63.15% -0.03%
==========================================
Files 308 308
Lines 40813 40829 +16
Branches 5654 5658 +4
==========================================
Hits 25784 25784
- Misses 14016 14032 +16
Partials 1013 1013
☔ View full report in Codecov by Sentry. |
|
@shnizzedy Is this something you're familiar with at all? I've never used the gantt chart functionality. |
|
I'll take a look at this when I have a chance. In the meantime, @hjmjohnson check out #3290. You might be able to get these charts drawn from there, although I'm not sure if #3527 (comment) is from a change newer than when I drafted that PR |
hjmjohnson
force-pushed
the
fix-draw-gantt-chart
branch
from
1458032
to
ad0e760
Compare
This patch attempts to convert string date representations back to datetime.date objects so that compuations can be done on them.
hjmjohnson
force-pushed
the
fix-draw-gantt-chart
branch
from
ad0e760
to
c749dbf
Compare
|
@shnizzedy I think this is still a relevant issue and that the code fixes the bug. Could you please review? |
This patch attempts to convert string date representations back to datetime.date objects to that computations
can be done on them.
Summary
Partially Fixes #3527
List of changes proposed in this PR (pull request)
After fixing the string-to-date object crash, other crashes began to appear. Hopefully, a more knowledgeable person can identify what needs to happen quickly.