-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] converting tests from nibabel/tests/ #840
Conversation
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
==========================================
- Coverage 90.09% 89.82% -0.27%
==========================================
Files 98 99 +1
Lines 12450 12474 +24
Branches 2188 2190 +2
==========================================
- Hits 11217 11205 -12
- Misses 883 915 +32
- Partials 350 354 +4
Continue to review full report at Codecov.
|
.travis.yml
Outdated
pytest -v../nibabel/tests/test_e*.py ../nibabel/tests/test_f*.py ../nibabel/tests/test_h*.py | ||
pytest -v../nibabel/tests/test_i*.py ../nibabel/tests/test_k*.py ../nibabel/tests/test_l*.py ../nibabel/tests/test_m*.py | ||
pytest -v../nibabel/tests/test_n*.py ../nibabel/tests/test_o*.py ../nibabel/tests/test_p*.py ../nibabel/tests/test_q*.py | ||
pytest -v ../nibabel/tests/test_w*.py | ||
pytest -v ../nibabel/tests/test_affines.py ../nibabel/tests/test_volumeutils.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test the installed version of nibabel, we can use:
pytest --pyargs nibabel
See https://docs.pytest.org/en/latest/goodpractices.html#tests-as-part-of-application-code
…reason cant run the tests in one pytest command, so added an extra line to travis for now
…helping functions)
…ass check to all of the test methods: couldnt find better way for suppressing tests from abstract classes and allowing for testing from all child classes
c75e85a
to
bb2c02a
Compare
@djarecka I rebased your changes on the If you'd prefer, I can move the pytest branch to upstream, and we can make PRs against it while we move to pytest. Whatever you like. |
@effigies - sorry, have been planning to finish this sooner. I'll come back to this at the beginning of Feb, and hopefully will finish in one session. |
@djarecka No worries. Just saw that nose is going to start failing on Python 3.9, so thinking of trying to sprint on it: https://twitter.com/effigies/status/1220097622276562945 Got a few responses, so I wanted to see what the status of this one was. I'll open an issue for general discussion. |
will be adding more tests