Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] converting tests from nibabel/tests/ #840

Closed
wants to merge 15 commits into from

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Nov 11, 2019

will be adding more tests

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #840 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   90.09%   89.82%   -0.27%     
==========================================
  Files          98       99       +1     
  Lines       12450    12474      +24     
  Branches     2188     2190       +2     
==========================================
- Hits        11217    11205      -12     
- Misses        883      915      +32     
- Partials      350      354       +4
Impacted Files Coverage Δ
nibabel/optpkg.py 89.74% <ø> (ø) ⬆️
nibabel/testing_pytest/__init__.py 77.22% <100%> (+15.22%) ⬆️
nibabel/testing_pytest/helpers.py 100% <100%> (ø)
nibabel/quaternions.py 89.21% <0%> (-9.81%) ⬇️
nibabel/data.py 78.04% <0%> (-8.95%) ⬇️
nibabel/pkg_info.py 75.75% <0%> (-6.07%) ⬇️
nibabel/nicom/dicomwrappers.py 85.16% <0%> (-5.75%) ⬇️
nibabel/eulerangles.py 91.66% <0%> (-3.34%) ⬇️
nibabel/processing.py 97.33% <0%> (-2.67%) ⬇️
nibabel/volumeutils.py 91.29% <0%> (-1.36%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc44ae...bb2c02a. Read the comment docs.

@djarecka djarecka changed the title converting tests with tests/test_a*.py and test_wrapstruct (for some … [wip] converting tests from nibabel/tests/ Nov 12, 2019
.travis.yml Outdated
pytest -v../nibabel/tests/test_e*.py ../nibabel/tests/test_f*.py ../nibabel/tests/test_h*.py
pytest -v../nibabel/tests/test_i*.py ../nibabel/tests/test_k*.py ../nibabel/tests/test_l*.py ../nibabel/tests/test_m*.py
pytest -v../nibabel/tests/test_n*.py ../nibabel/tests/test_o*.py ../nibabel/tests/test_p*.py ../nibabel/tests/test_q*.py
pytest -v ../nibabel/tests/test_w*.py
pytest -v ../nibabel/tests/test_affines.py ../nibabel/tests/test_volumeutils.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test the installed version of nibabel, we can use:

pytest --pyargs nibabel

See https://docs.pytest.org/en/latest/goodpractices.html#tests-as-part-of-application-code

@effigies
Copy link
Member

effigies commented Jan 25, 2020

@djarecka I rebased your changes on the maint/3.0.x branch. If you'd like to check maint/3.0.x...effigies:ci/pytest_nibabeltests, and you're happy with the changes, you can reset to that branch.

If you'd prefer, I can move the pytest branch to upstream, and we can make PRs against it while we move to pytest. Whatever you like.

@djarecka
Copy link
Collaborator Author

@effigies - sorry, have been planning to finish this sooner. I'll come back to this at the beginning of Feb, and hopefully will finish in one session.

@effigies
Copy link
Member

@djarecka No worries. Just saw that nose is going to start failing on Python 3.9, so thinking of trying to sprint on it: https://twitter.com/effigies/status/1220097622276562945

Got a few responses, so I wanted to see what the status of this one was. I'll open an issue for general discussion.

This was referenced Jan 25, 2020
@effigies effigies closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants