Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Import abstract classes from collections.abc for Python 3.8 compatibility #711

Merged
merged 3 commits into from
Jan 14, 2019

Conversation

larsoner
Copy link
Contributor

Fixes imports that cause:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage increased (+0.003%) to 91.827% when pulling 8fa9b29 on larsoner:collections into 8b1a1b2 on nipy:master.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. Very small suggestion.

nibabel/cifti2/cifti2.py Show resolved Hide resolved
nibabel/externals/oset.py Show resolved Hide resolved
@effigies effigies changed the title BUG: Fix deprecated imports MAINT: Import abstract classes from collections.abc for Python 3.8 compatibility Jan 13, 2019
@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #711 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   88.83%   88.84%   +<.01%     
==========================================
  Files          93       93              
  Lines       11460    11464       +4     
  Branches     1896     1896              
==========================================
+ Hits        10181    10185       +4     
  Misses        937      937              
  Partials      342      342
Impacted Files Coverage Δ
nibabel/cifti2/cifti2.py 96.38% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1a1b2...8fa9b29. Read the comment docs.

@effigies effigies merged commit d45417a into nipy:master Jan 14, 2019
@larsoner larsoner deleted the collections branch January 17, 2019 15:31
@effigies effigies added this to the 2.4.0 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants