STY: Enforce ruff/flake8-pyi rules (PYI) #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1355 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 207 207
Lines 29494 29494
Branches 4978 4978
=======================================
Hits 28122 28122
Misses 932 932
Partials 440 440 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Sep 22, 2024
| @@ -22,6 +22,7 @@ | |||
| from types import TracebackType | |||
|
|
|||
| from _typeshed import WriteableBuffer | |||
| from typing_extensions import Self | |||
There was a problem hiding this comment.
Need to add this to dependencies. Should guard and import from typing for Python <3.11, and then we can use typing_extensions >=VER; python_version < '3.11'.
Ah, I see, it's in ty.TYPE_CHECKING guard. We should add to tox:
Lines 172 to 186 in d1930e9
There was a problem hiding this comment.
Add typing_extensions.
DimitriPapadopoulos
force-pushed
the
PYI
branch
2 times, most recently
from
93b272d
to
f56bcff
Compare
effigies
approved these changes
Sep 22, 2024
DimitriPapadopoulos
force-pushed
the
PYI
branch
from
f56bcff
to
cd9022c
Compare
PYI034 `__enter__` methods usually return `self` at runtime
DimitriPapadopoulos
force-pushed
the
PYI
branch
from
cd9022c
to
df862cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.