Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Accommodate pytest 8 changes #1297

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

effigies
Copy link
Member

In earlier pytest, the following would "xfail":

@pytest.mark.xfail(raises=SomeException)
def example:
    with pytest.warns(SomeWarning):
        raise SomeException

Now, the failure to raise SomeWarning prior to raising an exception causes the test to fail in an unexpected way, presumably due to the order of exception chaining.

This PR adjusts our expected warning check to be disabled if an exception is expected to come first.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (5d884bd) to head (cff2936).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
+ Coverage   92.23%   92.25%   +0.01%     
==========================================
  Files          99       99              
  Lines       12461    12467       +6     
  Branches     2562     2563       +1     
==========================================
+ Hits        11494    11502       +8     
+ Misses        643      642       -1     
+ Partials      324      323       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 27c2427 into nipy:master Feb 23, 2024
52 checks passed
effigies added a commit that referenced this pull request Feb 27, 2024
effigies added a commit that referenced this pull request Feb 27, 2024
5.2.1 (Monday 26 February 2024)

Bug-fix release in the 5.2.x series.

Enhancements
------------
* Support "flat" ASCII-encoded GIFTI DataArrays (pr/1298) (PM, reviewed by CM)

Bug fixes
---------
* Tolerate missing ``git`` when reporting version info (pr/1286) (CM, reviewed by
  Yuri Victorovich)
* Handle Siemens XA30 derived DWI DICOMs (pr/1296) (CM, reviewed by YOH and
  Mathias Goncalves)

Maintenance
-----------
* Add tool for generating GitHub-friendly release notes (pr/1284) (CM)
* Accommodate pytest 8 changes (pr/1297) (CM)

* tag '5.2.1':
  REL: 5.2.1
  Backport gh-1296: Conditionally drop derived volumes from DWI sequences
  Backport gh-1298: Support "flat" ASCII-encoded GIFTI DataArrays
  Build(deps): Bump codecov/codecov-action from 3 to 4
  Build(deps): Bump the actions-infrastructure group with 3 updates
  Backport gh-1297: Accommodate pytest 8 changes
  Backport gh-1286: Tolerate missing git
  MNT: Advertise Python 3.12 support
  DOC: Fix intersphinx mapping and reference type
  Backport gh-1284: Add tool for generating GitHub-friendly release notes
@effigies effigies deleted the fix/pytest branch October 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant