-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Warn on invalid MINC2 spacing declarations, treat as missing #1237
Conversation
Accept other values (like `xspacing`), assuming regular spacing. nipy#1236
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 98 98
Lines 12364 12368 +4
Branches 2539 2540 +1
=======================================
+ Hits 11395 11399 +4
Misses 646 646
Partials 323 323
☔ View full report in Codecov by Sentry. |
Co-authored-by: Chris Markiewicz <[email protected]>
We should test this. Opened a PR against your branch: petsuter#1 |
TEST: Add test file with bad spacing field
Thanks very much! Would you like to add yourself to the Zenodo file as a contributor? https://github.com/nipy/nibabel/blob/master/.zenodo.json |
Thanks, done. |
Accept other values (like
xspacing
), assuming regular spacing. #1236