Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Warn on invalid MINC2 spacing declarations, treat as missing #1237

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

petsuter
Copy link
Contributor

Accept other values (like xspacing), assuming regular spacing. #1236

Accept other values (like `xspacing`), assuming regular spacing.
nipy#1236
nibabel/minc2.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (064e80d) 92.16% compared to head (ba88e43) 92.16%.

❗ Current head ba88e43 differs from pull request most recent head 1402f18. Consider uploading reports for the commit 1402f18 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1237   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          98       98           
  Lines       12364    12368    +4     
  Branches     2539     2540    +1     
=======================================
+ Hits        11395    11399    +4     
  Misses        646      646           
  Partials      323      323           
Impacted Files Coverage Δ
nibabel/minc2.py 90.47% <80.00%> (+0.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

We should test this. Opened a PR against your branch: petsuter#1

TEST: Add test file with bad spacing field
@effigies effigies changed the title ENH: only warn about invalid Minc2 spacing declaration ENH: Warn on invalid MINC2 spacing declarations, treat as missing Jul 13, 2023
@effigies
Copy link
Member

Thanks very much! Would you like to add yourself to the Zenodo file as a contributor?

https://github.com/nipy/nibabel/blob/master/.zenodo.json

@petsuter
Copy link
Contributor Author

Thanks, done.

@effigies effigies merged commit 6fe3e6b into nipy:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants