-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] lighter alpine multi-stage build docker image, ~65% smaller #791
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 42 42
Lines 4323 4323
=======================================
Hits 3566 3566
Misses 757 757 ☔ View full report in Codecov by Sentry. |
Why in hell do the 3.9+ tests crash when just changeing the dockerfile that is not used in the tests!? 🤯 |
Nibabel nipy/nibabel#1336 broke heudiconv tests via dcmstack. |
Heudiconv itself could be made lighter if this wasn't 12MB https://github.com/nipy/heudiconv/tree/master/heudiconv/tests/data/b0dwiForFmap |
0807931
to
3568ed8
Compare
forced-push to get the tests to pass with newer nibabel version. |
Thanks for cooking it up. For now I just merged "my smaller PR #790" progressing forward base versions. I wonder if we could/should position this one as |
Make sense, I will work on the changes. |
3568ed8
to
a2df952
Compare
Disclaimer: I don't know enough about Neurodocker and Reproenv to know if these are critical to run heudiconv image in specific contexts or if there are any advantages compared to a bare alpine version.
Alpine allow:
Also:
I might have forgotten some non-pip managed heudiconv reqs, it would be safer for the
docker.yml
workflow to run the tests on the image before pushing to dockerhub. Also, ifbash
or other term stuffs are used in specific deployment, it can be added.