Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_private_csa_header test write to temp dir #666

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 11, 2023

The runner() call in test_private_csa_header in test_dicoms.py did not specify an outdir, and so the test was creating files in the current directory, which is the repository root when testing locally with tox. This PR fixes the test to instead write to a temporary directory.

@jwodder jwodder added the tests Add or improve existing tests label Apr 11, 2023
@yarikoptic
Copy link
Member

Thank you! It remains green, so all good

@yarikoptic yarikoptic merged commit ea93aec into master Apr 11, 2023
@yarikoptic yarikoptic deleted the no-research-dir branch April 11, 2023 23:37
@github-actions
Copy link

github-actions bot commented May 8, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants