Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample_nifti.json to .gitignore #663

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add sample_nifti.json to .gitignore #663

merged 1 commit into from
Apr 12, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 10, 2023

One of the tests creates a sample_nifti.json file in the heudiconv/tests/data/ directory, and this file needs to be in the same directory as some of the files that are already in the data/ directory (and so creating it in a temp directory won't work). This PR thus adds the file to .gitignore so that it will be ignored by Git.

@jwodder jwodder added the internal Changes only affect the internal API label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0c3f14b) 81.57% compared to head (764e998) 81.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          43       43           
  Lines        3929     3929           
=======================================
  Hits         3205     3205           
  Misses        724      724           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

I already merged some PR and caused conflict.

I am with a workaround for now, but ideally that test_get_key_info_for_fmap_assignment should be fixed - probably sample NIFTI file first copied to temp dir and then used in there. I missed the fact that we are modifying the tests directory - that makes heudiconv being untestable without write access to tests, which isn't good.

@jwodder
Copy link
Member Author

jwodder commented Apr 11, 2023

@yarikoptic Conflict resolved, and issue #665 created for updating the test.

@yarikoptic yarikoptic merged commit f5d71b7 into master Apr 12, 2023
@yarikoptic yarikoptic deleted the ign-nifti branch April 12, 2023 03:34
@github-actions
Copy link

github-actions bot commented May 8, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants