Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kludgy support for older versions of pydicom and dcmstack #662

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 10, 2023

By requiring pydicom >= 1.0.0 and dcmstack >= 0.7.0 (the latter of which we already do a stronger version of), we no longer need any kludgy workarounds to support older versions.

@jwodder jwodder added the dependencies Update one or more dependencies version label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.24 🎉

Comparison is base (012895d) 81.22% compared to head (ff605d8) 81.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   81.22%   81.47%   +0.24%     
==========================================
  Files          43       41       -2     
  Lines        3925     3902      -23     
==========================================
- Hits         3188     3179       -9     
+ Misses        737      723      -14     
Impacted Files Coverage Δ
heudiconv/heuristics/multires_7Tbold.py 14.28% <0.00%> (ø)
heudiconv/info.py 100.00% <ø> (ø)
heudiconv/bids.py 90.51% <100.00%> (ø)
heudiconv/dicoms.py 86.20% <100.00%> (ø)
heudiconv/tests/test_dicoms.py 85.88% <100.00%> (ø)
heudiconv/tests/test_regression.py 93.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder jwodder force-pushed the pydicom branch 2 times, most recently from fd65737 to e9252c1 Compare April 11, 2023 12:31
@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit ca0ba8e into master Apr 12, 2023
@yarikoptic yarikoptic deleted the pydicom branch April 12, 2023 03:33
@github-actions
Copy link

github-actions bot commented May 8, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants