strip non-alphanumeric from session ids too #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on needed orig value was useful only for debugging, but then code could be instrumented if needed. removing helper function actually makes code more readable. do not duplicate "check" (isalnum) - always call sanitize
yarikoptic
added
minor
Codecov ReportBase: 81.32% // Head: 81.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
==========================================
+ Coverage 81.32% 81.36% +0.04%
==========================================
Files 42 42
Lines 3828 3837 +9
==========================================
+ Hits 3113 3122 +9
Misses 715 715
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extended #540 with tests and minor code refactoring.
As we accumulated good number of changes, marking for release with this PR. If all green etc -- will proceed with the release.