Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .dockerignore #607

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Delete .dockerignore #607

merged 1 commit into from
Nov 3, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 3, 2022

Closes #606.

Excluding version-controlled files from the Docker image causes the resulting copy of the repository inside the image to be dirty, which in turn results in "+dDATE" added to the version number.

Excluding version-controlled files from the Docker image causes the resulting
copy of the repository inside the image to be dirty, which in turn results in
"+dDATE" added to the version number.
@jwodder jwodder added the internal Changes only affect the internal API label Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 81.28% // Head: 81.28% // No change to project coverage 👍

Coverage data is based on head (0d16623) compared to base (151f25a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          41       41           
  Lines        3815     3815           
=======================================
  Hits         3101     3101           
  Misses        714      714           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

oh, thank you!

@yarikoptic yarikoptic merged commit 4ac084b into master Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

🚀 PR was released in v0.11.6 🚀

@jwodder jwodder deleted the gh-606 branch April 10, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gets unnecessary +dDATE added to a version corresponding to a clean release
2 participants