Remove .git/ from .dockerignore so that versioning works while building docker image #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng docker image Note: that implies that local .git/ better does not contain any sensitive data
yarikoptic
added
release
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 81.26% 81.24% -0.03%
==========================================
Files 41 41
Lines 3817 3817
==========================================
- Hits 3102 3101 -1
- Misses 715 716 +1
Continue to review full report at Codecov.
|
|
Travis testing is unrelated -- let's proceed with merge and see what happens |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: that implies that local .git/ better does not contain any sensitive data. We should be building off github action fresh clone, should be safe AFAIK
Closes #516
Marking for release so we get 0.11.1 with a docker image on the hub (hopefully)