BF(TST): use caplog to control logging level, use python3 in shebang #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing for me locally since logging by default was above INFO, and I had no python but python3. Since we are operating in python3 realm ATM, I have decided to just change the shebang accordingly
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 41 41
Lines 3784 3785 +1
=======================================
+ Hits 3073 3074 +1
Misses 711 711
Continue to review full report at Codecov.
|
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing for me locally since logging by default was above INFO, and
I had no python but python3. Since we are operating in python3 realm ATM, I have
decided to just change the shebang accordingly.
Since PR is trivial, will merge it as soon as CI is happy