Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adds "AcquisitionTime" to the seqinfo #487

Merged
merged 5 commits into from
Jan 13, 2021
Merged

ENH: Adds "AcquisitionTime" to the seqinfo #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ac551e
ENH: Adds "AcquisitionTime" to the `seqinfo`
pvelasco Jan 6, 2021
5b33646
Switch back order of seqinfo_fields
pvelasco Jan 7, 2021
74d55d5
Switch back order of SeqInfo arguments in dicom.py
pvelasco Jan 8, 2021
0fb0c2f
Adds unittest to check "time" in the right position in dicominfo.tsv
pvelasco Jan 8, 2021
2768e7a
BF(py3.5): explicitly case path to str for open
yarikoptic Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion heudiconv/dicoms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ def create_seqinfo(mw, series_files, series_id):
patient_age=dcminfo.get('PatientAge'),
patient_sex=dcminfo.get('PatientSex'),
date=dcminfo.get('AcquisitionDate'),
series_uid=dcminfo.get('SeriesInstanceUID')
series_uid=dcminfo.get('SeriesInstanceUID'),
time=dcminfo.get('AcquisitionTime'),
)
return seqinfo

Expand Down
5 changes: 5 additions & 0 deletions heudiconv/tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,11 @@ def test_cache(tmpdir):
assert (cachedir / 'S01.auto.txt').exists()
assert (cachedir / 'S01.edit.txt').exists()

# check dicominfo has "time" as last column:
with open(str(cachedir / 'dicominfo.tsv'), 'r') as f:
cols = f.readline().split()
assert cols[26] == "time"


def test_no_etelemetry():
# smoke test at large - just verifying that no crash if no etelemetry
Expand Down
3 changes: 2 additions & 1 deletion heudiconv/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
'patient_sex', # 23
'date', # 24
'series_uid', # 25
]
'time', # 26
]

SeqInfo = namedtuple('SeqInfo', seqinfo_fields)

Expand Down