Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: allow additional dcm2niix configuration #208

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented May 9, 2018

Fixes #206

  • allow passing of an interface config through the use of Nipype's BaseInterface.__init__(from_file)

@codecov-io
Copy link

Codecov Report

Merging #208 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   68.29%   68.28%   -0.01%     
==========================================
  Files          30       30              
  Lines        2359     2362       +3     
==========================================
+ Hits         1611     1613       +2     
- Misses        748      749       +1
Impacted Files Coverage Δ
heudiconv/cli/run.py 75% <100%> (+0.16%) ⬆️
heudiconv/convert.py 76.88% <80%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3e823...c78d25b. Read the comment docs.

@mgxd
Copy link
Member Author

mgxd commented May 11, 2018

no objections?

@yarikoptic
Copy link
Member

what is the usecase you are trying to fulfill? i.e. what custom option needs to be passed which should not be a part of the heuristic (as --bids should become)?

@yarikoptic
Copy link
Member

hm, one use case just came up: rordenlab/dcm2niix#198


convertnode = Node(Dcm2niix(), name='convert')
convertnode = Node(Dcm2niix(from_file=fromfile), name='convert')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the light of #273 -- when was from_file treatment introduced? seems to be not in 0.12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_file is s generic keyword for all interfaces to load configuration settings from a json file.

@mgxd mgxd merged commit 3700462 into nipy:master Jan 23, 2019
@mgxd mgxd mentioned this pull request Jan 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants