-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: allow additional dcm2niix configuration #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 68.29% 68.28% -0.01%
==========================================
Files 30 30
Lines 2359 2362 +3
==========================================
+ Hits 1611 1613 +2
- Misses 748 749 +1
Continue to review full report at Codecov.
|
no objections? |
what is the usecase you are trying to fulfill? i.e. what custom option needs to be passed which should not be a part of the heuristic (as --bids should become)? |
hm, one use case just came up: rordenlab/dcm2niix#198 |
|
||
convertnode = Node(Dcm2niix(), name='convert') | ||
convertnode = Node(Dcm2niix(from_file=fromfile), name='convert') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the light of #273 -- when was from_file
treatment introduced? seems to be not in 0.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from_file
is s generic keyword for all interfaces to load configuration settings from a json file.
Fixes #206
Nipype
'sBaseInterface.__init__(from_file)