Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import error when .heudiconv file exists in path with a heuristic python file #470

Closed
1 task
CalebRHaynes opened this issue Oct 23, 2020 · 1 comment
Closed
1 task

Comments

@CalebRHaynes
Copy link

Summary

Hi!

I have found it easier to pull the information I need to make a heuristic out of the .heudiconv directory and keeping it in my code directory. I realized today that if the hidden path still exists the -f flag will only look in the .hedudiconv folder and then thtow a module not found error (because it is no longer in the .heudiconv folder).

I think it would be a great feature to have an option in our workflow to only output the dicominfo.tsv and a minimal heuristic.py template (with -f convertall -c none) because it would be easier than moving files from the hidden folder and then moving the folder each time.

If someone can point me to where the code is for this issue and doesn't think our workflow sounds untenable or I am misunderstanding the script I could give a shot at trying it as well. Thanks so much!

Best,
Caleb

Platform details:

Choose one:

  • Local environment
  • [ x] Container

singularity

  • Heudiconv version:

0.8.0

@CalebRHaynes
Copy link
Author

On second thought I think my folder structure just needs to change to accommodate. Thank you!!

yarikoptic pushed a commit that referenced this issue Dec 23, 2020
Addresses initial comments in PR #470
yarikoptic pushed a commit that referenced this issue Dec 23, 2020
It handles now either a path or a list of paths of json files.
The setting of the "TaskName" is removed from "embed_metadata_from_dicoms".
Addresses some change requests in PR #470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant