Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to get bval/bvec: converted but not copied to output #38

Closed
mgxd opened this issue Dec 12, 2016 · 8 comments · Fixed by #480
Closed

unable to get bval/bvec: converted but not copied to output #38

mgxd opened this issue Dec 12, 2016 · 8 comments · Fixed by #480

Comments

@mgxd
Copy link
Member

mgxd commented Dec 12, 2016

I'm processing some Prisma data and noticed heudiconv isn't outputing bvals or bvecs. When I run the conversion using command-line dcm2niix, the bvals/bvecs were successfully made.

I thought this was a problem with nipype's dcm2nii.py interface - but even after making these changes I was still unable to produce them. Any ideas as to what is causing this?

For reference, here is dcm2niix's stdout for my diffusion scans

@satra
Copy link
Member

satra commented Mar 18, 2017

this appears to work fine now.

@satra satra closed this as completed Mar 18, 2017
@Shotgunosine
Copy link
Contributor

I've got this error with dataset I'm working with now. I'll let you know if I figure out what's causing it.

@Shotgunosine
Copy link
Contributor

Turns out some subjects weren't headfirst supine, thus dcm2niix won't generate bvals/bvecs for GE scans.

@WillForan
Copy link

WillForan commented Jun 2, 2020

also hit the issue on 0.8.0

# in container
docker run --rm -it -v $(pwd):/in -v bids_out:/out nipy/heudiconv:latest \
   -b -o out \
   -c dcm2niix \
   -d '/in/{subject}*/*/*' \
   -f '/in/bids_heuristic.py' \
   -p \
   -s 11354

# or without
heudiconv \
   -b -o bids_out \
   -c dcm2niix \
   -d '{subject}*/*/*' \
   -f 'bids_heuristic.py' \
   -p \
   -s 11354

# but get bvec and bval with just dcm2niix
 dcm2niix -b y -z y -x n -t n -m n -f sub-11354_run-1_dwi -o d2n -s n -v n 11354/diff113_current_PA_1152x1152.16/
ls bids_out/sub-11354/dwi/
sub-11354_run-1_dwi.json  sub-11354_run-1_dwi.nii.gz  sub-11354_run-1_dwi_prov.ttl
 ls d2n/
sub-11354_run-1_dwi.bval  sub-11354_run-1_dwi.json
sub-11354_run-1_dwi.bvec  sub-11354_run-1_dwi.nii.gz

here's more as a gist:
https://gist.github.com/WillForan/d7dbcf83011d83b531ecb3f4519ab828

@yarikoptic
Copy link
Member

I think I have ran into this issue as well! Note that prior "lost bval/bvec" boiled down to need of fixing nipype: #13 ... yet to investigate in detail what is going on

@yarikoptic yarikoptic reopened this Dec 11, 2020
@yarikoptic yarikoptic changed the title unable to get bval/bvec unable to get bval/bvec: converted but not copied to output Dec 11, 2020
@yarikoptic
Copy link
Member

tested with nipype master (1.6.0-1-g47fe00b38, with that extra commit about mrtrix3, so unrelated) -- worked correctly! not sure what specific commit in nipype fixed up this issue yet. as much as love nipype and nipypers, but for a single interface of dcm2niix, it is imho too large of a beast (goes back to #6), heh. I guess we can resolve this issue by demanding nipype >= 1.6.0 , unless someone points to the fix more specifically.

@satra
Copy link
Member

satra commented Dec 11, 2020

i think nipype at one point served a few more things including provenance. but it's true at this point it would be advantages to turn dcm2niix into a pydra task and switch to pydra with all the parallelization that's possible and make heudiconv much leaner.

@yarikoptic
Copy link
Member

ok, manually bisected to nipy/nipype#2936 which appears in the git lg (one line) with descriptive rf+enh: dcm2niix ;-) it is 1.2.3~1^2 so we need at least that version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants