Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy.signal.cubic is now deprecated #370

Closed
oesteban opened this issue Jul 4, 2023 · 3 comments
Closed

scipy.signal.cubic is now deprecated #370

oesteban opened this issue Jul 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@oesteban
Copy link
Member

oesteban commented Jul 4, 2023

What happened?

https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.cubic.html#scipy.signal.cubic

What command did you use?

n/a

What version of the software are you running?

n/a

How are you running this software?

Docker

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

@oesteban oesteban added the bug Something isn't working label Jul 4, 2023
@effigies
Copy link
Member

effigies commented Jul 4, 2023

Well, at least BSpline has been around since 1.7 and they provide an exact equivalent. Last time we switched there was padding that increased runtime and had a weird edge case.

@oesteban
Copy link
Member Author

oesteban commented Jul 4, 2023

Another big plus to port to BSpline is that it also evaluates the derivative, which is necessary for calculating the jacobian (the next big thing)

@oesteban
Copy link
Member Author

Well, at least BSpline has been around since 1.7 and they provide an exact equivalent. Last time we switched there was padding that increased runtime and had a weird edge case.

I've submitted a new PR. Indeed the padding is there, so it'd be great to try to recap what was the weird edge case and check again if the increased runtime will be problematic.

effigies pushed a commit to effigies/sdcflows that referenced this issue Sep 24, 2023
effigies pushed a commit to effigies/sdcflows that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants