Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out phase, real, and imaginary data in collect_data #591

Closed
tsalo opened this issue Dec 8, 2020 · 2 comments · Fixed by #594
Closed

Filter out phase, real, and imaginary data in collect_data #591

tsalo opened this issue Dec 8, 2020 · 2 comments · Fixed by #594

Comments

@tsalo
Copy link
Contributor

tsalo commented Dec 8, 2020

BIDS has recently added a new entity, part, to indicate the part of the complex signal an MRI file corresponds to (see bids-standard/bids-specification#424). The default is magnitude, so files without the entity can be assumed to be useable (along with part-mag), but files with values of part-imag, part-real, and part-phase should be filtered out at data collection.

This new change also deprecated the phase suffix for phase fMRI data, and instead recommends using part-phase with the bold suffix, so this has the possibility of causing problems for both single-band reference images and BOLD files.

A minor note: The specification has not had a release since the part entity was added, but that will likely happen within the next month or so, so I thought it would be best to raise an issue here earlier rather than later.

@tsalo
Copy link
Contributor Author

tsalo commented Dec 8, 2020

Perhaps this could be done simply at the following location.

queries = {
"fmap": {"datatype": "fmap"},
"bold": {"datatype": "func", "suffix": "bold"},
"sbref": {"datatype": "func", "suffix": "sbref"},
"flair": {"datatype": "anat", "suffix": "FLAIR"},
"t2w": {"datatype": "anat", "suffix": "T2w"},
"t1w": {"datatype": "anat", "suffix": "T1w"},
"roi": {"datatype": "anat", "suffix": "roi"},
}

The change could be the following, although I'm not 100% sure. Thanks to @effigies for the recommendation!

queries = {
        "fmap": {"datatype": "fmap", "part": ["mag", None]},
        "bold": {"datatype": "func", "suffix": "bold", "part": ["mag", None]},
        "sbref": {"datatype": "func", "suffix": "sbref", "part": ["mag", None]},
        "flair": {"datatype": "anat", "suffix": "FLAIR", "part": ["mag", None]},
        "t2w": {"datatype": "anat", "suffix": "T2w", "part": ["mag", None]},
        "t1w": {"datatype": "anat", "suffix": "T1w", "part": ["mag", None]},
        "roi": {"datatype": "anat", "suffix": "roi"},
    }

@tsalo
Copy link
Contributor Author

tsalo commented Dec 6, 2023

I think #594 should have closed this.

@tsalo tsalo closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant