ENH: Add flip, inv, mt, and part entities #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves splitting the phase suffix from the bold, cbv, and sbref suffixes.
tsalo
commented
Dec 8, 2020
|
Since there's no way to specify that magnitude data should be assumed when |
tsalo
added a commit
to tsalo/pybids
that referenced
this pull request
May 3, 2021
effigies
pushed a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIDS has added new entities for flip angle (
flip), inversion time (inv), magnetization transfer state (mt), and component of the complex signal (part). These entities have been merged into the specification, but the updates haven't been released yet, although we expect a release within the next month or so.I didn't see any associated tests for the
echoentity, so I'm guessing that there are no tests associated with the config files. Please correct me if I'm wrong.Changes proposed:
flip,inv,mt, andpartentities.partinto path patterns. The other entities have not been integrated into any suffixes yet, as there are still BEP001-related PRs pending.