Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Plugin inclusion via main bootstrap file did not work #64

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

oesteban
Copy link
Member

This PR removes one dictionary level in the configuration of plugins. This was already effected on the initialization via plugins argument of the Report, but didn't work for the bootstrap file.

This PR removes one dictionary level in the configuration of plugins.
This was already effected on the initialization via ``plugins`` argument
of the ``Report``, but didn't work for the bootstrap file.
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7424386) 55.59% compared to head (0fc5d62) 55.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files          19       19           
  Lines        1806     1806           
  Branches      362      362           
=======================================
  Hits         1004     1004           
  Misses        728      728           
  Partials       74       74           
Flag Coverage Δ
unittests 55.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nireports/assembler/report.py 94.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oesteban oesteban merged commit 2269b86 into main Mar 25, 2023
@oesteban oesteban deleted the fix/loading-plugins-bug branch March 25, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants