Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Address memory issues and corruption in fMRIPlot #131

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

oesteban
Copy link
Member

At the same time, this PR ensures that all calls to plt.savefig() are followed by closing the figure.

Resolves: #129.
Closes: #130.

At the same time, this PR ensures that all calls to ``plt.savefig()``
are followed by closing the figure.

Resolves: #129.
Closes: #130.
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.21%. Comparing base (e0a30e6) to head (065fd2a).
Report is 4 commits behind head on main.

Files Patch % Lines
nireports/reportlets/modality/func.py 45.45% 4 Missing and 2 partials ⚠️
nireports/interfaces/dmri.py 0.00% 2 Missing ⚠️
nireports/interfaces/fmri.py 0.00% 1 Missing ⚠️
nireports/reportlets/nuisance.py 93.75% 1 Missing ⚠️
nireports/reportlets/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   59.20%   59.21%   +0.01%     
==========================================
  Files          20       20              
  Lines        2238     2256      +18     
  Branches      398      402       +4     
==========================================
+ Hits         1325     1336      +11     
- Misses        814      820       +6     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oesteban oesteban merged commit a45e814 into main Aug 25, 2024
23 checks passed
@oesteban oesteban deleted the fix/129-funky-fmriplot branch August 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigPlot may have a memory leak Funky fMRIPlots with multiecho datasets
1 participant