Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not attempt to calculate TA if SliceTiming is degenerate #2901

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Dec 3, 2022

Fixes #2867.

@effigies effigies added this to the 22.0.3 milestone Dec 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Base: 45.24% // Head: 45.83% // Increases project coverage by +0.59% 🎉

Coverage data is based on head (2ff25cb) compared to base (bdcc1d1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
+ Coverage   45.24%   45.83%   +0.59%     
==========================================
  Files          43       44       +1     
  Lines        3437     3637     +200     
==========================================
+ Hits         1555     1667     +112     
- Misses       1882     1970      +88     
Impacted Files Coverage Δ
fmriprep/workflows/bold/outputs.py 22.46% <100.00%> (+0.16%) ⬆️
fmriprep/_version.py 42.09% <0.00%> (-2.63%) ⬇️
fmriprep/cli/tests/test_version.py 99.04% <0.00%> (-0.96%) ⬇️
fmriprep/cli/run.py 3.50% <0.00%> (-0.84%) ⬇️
fmriprep/workflows/bold/base.py 16.39% <0.00%> (-0.56%) ⬇️
fmriprep/reports/core.py 53.84% <0.00%> (ø)
fmriprep/interfaces/multiecho.py 79.31% <0.00%> (ø)
fmriprep/workflows/bold/confounds.py 10.49% <0.00%> (ø)
fmriprep/workflows/bold/resampling.py 10.32% <0.00%> (ø)
fmriprep/utils/debug.py 20.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies changed the base branch from master to maint/22.0.x December 4, 2022 16:50
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just to confirm, we're counting on the validator to catch cases where SliceTiming is not an array?

@effigies
Copy link
Member Author

effigies commented Dec 5, 2022

Yes.

@effigies effigies merged commit a7862c1 into nipreps:maint/22.0.x Dec 5, 2022
@effigies effigies deleted the fix/degenerate_stc branch December 5, 2022 16:48
@effigies effigies modified the milestones: 22.0.3, 22.1.0 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Defined but empty SliceTiming should be skipped
3 participants