Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT/CI: Update fast track outputs, use latest smriprep #2894

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Nov 21, 2022

Anatomicals were generated using smriprep built off nipreps/smriprep@05a762b

@mgxd
Copy link
Collaborator Author

mgxd commented Nov 23, 2022

This is working as expected, installation problems seem unrelated and likely related to new pip updates (#2895)

@effigies
Copy link
Member

It doesn't seem to be new pip. Installing pip 22.1 in a Python 3.7 environment produces the same issue for me. I think there must be something in the dependency chain that's causing a resolution failure in 3.7. Pip's resolution mechanism is to find older and older versions of a tool, and we eventually found a nitime that is so old that it imports the entire module and breaks because numpy isn't a build dependency.

I think the thing to do is to drop Python 3.7. NEP29 recommended dropping it almost a year ago, and I assume that what we're seeing is the consequences of the broader ecosystem no longer testing on it. It's probably not worth a lot of effort tracking this down.

I would suggest we take one of the following routes:

  1. Adhere to NEP29 and drop Python minor releases along with the rest of the ecosystem.
  2. Continue testing and advertise support for non-EOL Pythons until the fixes become non-obvious.

@effigies
Copy link
Member

Squashing as this will be more coherent as a single commit. LGTM.

@effigies effigies merged commit 2c14a4a into nipreps:master Nov 30, 2022
@mgxd mgxd deleted the dep/smriprep branch December 6, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants