Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Output brain mask and boldref in BOLD space if individual echos requested #2852

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 12, 2022

Changes proposed in this pull request

If echos are output in BOLD space, it's useful to have a relevant mask. I'm not sure how useful the boldref is, but it shouldn't be very large.

Closes #2844.

Documentation that should be reviewed

  • Updated expected outputs (most cribbed from maint/22.0.x)

@effigies effigies added this to the 21.0.4 milestone Sep 29, 2022
@effigies effigies force-pushed the fix/output_masks_for_echos branch from eed4e5d to d0278c7 Compare September 29, 2022 11:59
@effigies
Copy link
Member Author

@mgxd Should be a quick review...

fmriprep/workflows/bold/outputs.py Outdated Show resolved Hide resolved
@effigies effigies merged commit 21dc8fc into nipreps:maint/21.0.x Sep 29, 2022
@effigies effigies deleted the fix/output_masks_for_echos branch September 29, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants