Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Revise dependencies #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MAINT: Revise dependencies #185

wants to merge 1 commit into from

Conversation

oesteban
Copy link
Member

Remove packages not imported directly by dMRIPrep and update some
version pins such as PyBIDS'.

Remove packages not imported directly by dMRIPrep and update some
version pins such as PyBIDS'.
Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not running, because pip can't find find those URLs. I wonder whether they should be git+https URLs?

indexed_gzip >=0.8.8
nibabel ~= 3.0
nipype >= 1.5.1, < 2.0
niworkflows >= 1.4.0rc6, <1.5
niworkflows @ https://github.com/nipreps/niworkflows.git@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be?

Suggested change
niworkflows @ https://github.com/nipreps/niworkflows.git@master
niworkflows @ git+https://github.com/nipreps/niworkflows.git@master

Looks like pip isn't finding this URL: https://github.com/nipreps/dmriprep/runs/3997021118?check_suite_focus=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

smriprep >= 0.8.0rc2
svgutils != 0.3.2
sdcflows @ https://github.com/nipreps/sdcflows.git@master
smriprep @ https://github.com/nipreps/smriprep.git@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for these two, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants