Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update readme and delete contributing guidelines in favour of nipreps website #127

Merged
merged 3 commits into from
Nov 11, 2020
Merged

DOC: Update readme and delete contributing guidelines in favour of nipreps website #127

merged 3 commits into from
Nov 11, 2020

Conversation

josephmje
Copy link
Collaborator

@josephmje josephmje commented Nov 10, 2020

I also fixed a typo in the figure1 svg file but wasn't sure how to render it into png.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a few nitpicks

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@oesteban
Copy link
Member

We should probably rebase this into master - there are many commits there that I don't think are necessary.

dmriprep/utils/images.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #127 (b496fb7) into master (26a64f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   50.27%   50.27%           
=======================================
  Files          21       21           
  Lines        1289     1289           
  Branches      169      169           
=======================================
  Hits          648      648           
  Misses        629      629           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a64f0...e2959e4. Read the comment docs.

@oesteban oesteban merged commit 7027aa9 into nipreps:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants