Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add base SVG file for the "figure1" (aka the workflow) flowchart #124

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

oesteban
Copy link
Member

I have taken a stab at mapping the whiteboard scribbles of our sprint into an SVG file.
IMG_1811

I've realized several things I will go over in our weekly meeting (in 30 min approx):

  • dMRIPrep SHOULD NOT concatenate runs (Concatenating different runs #43)
  • SDC (fieldmaps) requires transferring almost all responsibilities over to SDCFlows - that includes some of the issues that @mattcieslak raised within Concatenating different runs #43.
  • We need to reconsider where denoising should be inserted (and listen to what @jelleveraart has to say about this). The question is would denoising help have a better estimation of head motion and/or Eddy deformations?

Hopefully, this will help us progress faster towards our roadmap.

Resolves: #5

I have taken a stab at mapping the whiteboard scribbles of our sprint into an SVG file.

I've realized of several things I will go over in our weekly meeting (in 30 min aprox):

- *dMRIPrep* SHOULD NOT concatenate runs (#43)
- SDC (fieldmaps) requires transferring almost all responsibilities over to *SDCFlows* - that includes some of the issues that @mattcieslak raised within #43.
- We need to reconsider where denoising should be inserted (and listen what @jelleveraart has to say about this). The question is would denoising help have a better estimation of head motion and/or Eddy deformations?

Hopefully, this will help us progress faster towards our roadmap.

Resolves: #5
@oesteban
Copy link
Member Author

oesteban commented Oct 27, 2020

figure1

@dPys
Copy link
Collaborator

dPys commented Oct 27, 2020

This looks great @oesteban !

The only suggestion I have for improvement is that if we're indeed going to include denoising now, the noise map might ideally be generated early on in the pipeline (as indicated above), but the noise correction not be applied until the very end. There are several benefits to splitting up noise sigma estimation and applying actual denoising correction based on that noise profile. For one thing and in the spirit of a preference for single-shot resampling, all of the transforms estimated (i.e. for motion, eddy currents, etc.) from the DWI can be applied to the initial noise map (a 3d or 4d image) to ensure consistent voxelwise alignment while preserving the raw noise distribution. Furthermore, this approach is still also compatible with applying the denoising correction to just the B0 template at an earlier stage to improve eddy/motion correction, as @mattcieslak has suggested doing.

As soon as the denoising correction is actually applied to the DWI data, the underlying distribution of signal changes fundamentally; it's unclear how this would impact assumptions going into our implementation of eddy/motion correction, but for FSL's TOPUP/EDDY it tends to increases runtime and produces suboptimal correction.

@oesteban
Copy link
Member Author

Yup, as we've discussed in the meeting, it is not clear whether denoising should happen before HMC and ECC. It seems clear that it should not happen after resampling (and implicitly, after correction for HM, EC, and SD).

We'll let the data speak for themselves and compare both options. For now, we'll stick with the roadmap (addressing the corrections before anything else).

This SVG is meant to be just a starting point so I'll merge and invite everyone to modify it as they see fit.

@oesteban oesteban merged commit 26a64f0 into master Oct 27, 2020
@oesteban oesteban deleted the docs/workflow-figure branch October 27, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow figure 1
2 participants