New iniReader implementation #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine for me, settings + trainer stuff seemed to save fine at least, and cmd line args all looked okay, debug tool stuff like area jump still saved fine also. I noticed this branch mentions "New refresh rate = 70" in console (I'm still using the OC'd monitor stuff I mentioned at #419 (comment)) - not sure if that means this is actually using that mode to display though, but IIRC I didn't see that message with the other branch. |
|
Ah, nice! Many thanks for taking a look. |
nipkownix
force-pushed
the
new-iniReader
branch
from
5983f24
to
792b836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@emoose This should fix part of #405, as mentioned here: #405 (comment)
Figured it was time we made our own .ini reader to fit our needs instead of fighting the existing one.
This is a bit simplified if compared to the original one, but I only focused on what we are actually using for now.Our extended
CmdIniReaderis now part of this too, so everything feels a bit cleaner.Never tried doing this before, so I figured I should get your input before a potential merge. Everything seems to be working fine, though.
Edit: Was looking for a way to stop using
WritePrivateProfileStringsince that is terribly slow, outdated, unsupported, and the only reason we had a separate thread to write settings. Came across simpleini, which can write back the .ini preserving comments and doesn't touch any of the outdatedxxPrivateProfileStringfuncs. Seems pretty quick as well, so I removed the thread stuff we were using.Should probably triple-check if everything is saving fine, though ._.