Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having an option to ignore generator rule/statement #1585

Closed
bobzhang opened this issue May 30, 2019 · 5 comments
Closed

Having an option to ignore generator rule/statement #1585

bobzhang opened this issue May 30, 2019 · 5 comments

Comments

@bobzhang
Copy link

By default, ninja already ignore generator rules, but it does not work on CI sometimes, when doing a git clone, the timestamp is lost

@jhasse
Copy link
Collaborator

jhasse commented Jun 4, 2019

I'm not sure I understand what you mean. Is your build manifest not in Git?

@bobzhang
Copy link
Author

bobzhang commented Jun 5, 2019 via email

@bauen1
Copy link

bauen1 commented Jun 5, 2019

@bobzhang You're probably looking for a tool like git-restore-mtime to correct the time stamps of the repo after checkout for CI.

This doesn't seem to be an issue with ninja, since it is behaving as expected (regenerating outdated build objects when needed).

@jhasse
Copy link
Collaborator

jhasse commented Jun 5, 2019

Or #1459 ;)

@jhasse jhasse closed this as completed Jun 5, 2019
@bobzhang
Copy link
Author

bobzhang commented Jun 8, 2019

It is not ninja's fault, but in an imperfect world it would be nice to have ninja provide a work around. I could use tools like @bauen1 mentioned, but I had to make it available in CI first..
#1459 is similar but not exactly the same, ideally I want to have a way to skip the generator rules completely without relying timestamps.
I have a local patch, I would like to send a PR if you are interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants