-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring to simplify logic/enhance flexibility #15
base: main
Are you sure you want to change the base?
Conversation
I’ve fixed |
Alright, I managed to get it working, but it might not be very intuitive. There might be a better way to approach this. The only issue now is that sometimes I don’t know why the newly created u.mp4(Automatically triggered at ~13s) Edit |
I believe I've fixed all the bugs I know of. There's nothing more I can do on my end. @ninetailsrabbit What are your thoughts? |
Hi @univeous, there are too many changes, I have seen them at a glance and I would need a moment of concentration to go through it all in detail. Even so, I appreciate your time, if you see that it works for you, keep at it. I think I will leave this repository a bit parked and I will focus on looking for a programming job since the needs of the real world are more important to me at the moment. |
Of course, no problem! Please proceed at your own pace. |
Description
I think some parts of the current implementation are overly complex while not being flexible enough.
I made the following changes:
shape
would suffice)Existing issues:
I plan to make some fixes, but I can't promise.
Done!Addressed issues