the total weight on each roll was not being resetted and nextFloat it…

…'s fixed
ninetailsrabbit · Jun 7, 2024 · a5da72c · a5da72c
1 parent 6b328a6
commit a5da72c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Match3Maker/Match3Maker.csproj b/Match3Maker/Match3Maker.csproj
@@ -14,7 +14,7 @@
 
 	<PropertyGroup>
 		<Title>Ninetailsrabbit.Match3Maker</Title>
-		<Version>1.0.8</Version>
+		<Version>1.0.9</Version>
 		<Description>This lightweight library provides the core logic and functionality you need to build engaging match-3 games. Focus on game design and mechanics while leaving the complex logic to this library</Description>
 		<Copyright>© 2024 Ninetailsrabbit</Copyright>
 		<Authors>Ninetailsrabbit</Authors>

diff --git a/Match3Maker/src/extensions/RandomExtension.cs b/Match3Maker/src/extensions/RandomExtension.cs
@@ -21,7 +21,7 @@ public static class RandomExtension {
         public static float NextFloat(this Random random, float minValue = float.MinValue, float maxValue = float.MaxValue) {
             double range = (double)maxValue - (double)minValue;
             double sample = random.NextDouble();
-            double scaled = (sample * range) + float.MinValue;
+            double scaled = (sample * range) + minValue;
 
             return (float)scaled;
         }

diff --git a/Match3Maker/src/features/PieceWeightGenerator.cs b/Match3Maker/src/features/PieceWeightGenerator.cs
@@ -19,6 +19,7 @@ public Piece Roll(List<Piece> pieces, IEnumerable<Type>? only = null) {
 
             do {
                 selectedPieces.ToList().Shuffle();
+                totalWeight = 0f;
 
                 foreach (Piece piece in selectedPieces) {
                     piece.ResetAccumWeight();
@@ -29,6 +30,7 @@ public Piece Roll(List<Piece> pieces, IEnumerable<Type>? only = null) {
 
                 float roll = _rng.NextFloat(0f, totalWeight);
 
+
                 foreach (Piece piece in selectedPieces) {
 
                     if (roll <= piece.TotalAccumWeight) {