Dev 3800 Privacy Plugin race condition when listening on enabled features

packages/plugins/privacy/src/NinetailedPrivacyPlugin.spec.ts

@@ -1,10 +1,10 @@
 /* eslint-disable @typescript-eslint/ban-ts-comment */
 import { Analytics, AnalyticsInstance } from 'analytics';
-import { PLUGIN_NAME as NINETAILED_CORE_PLUGIN_NAME } from '@ninetailed/experience.js';
 import {
-  FEATURES,
+  PLUGIN_NAME as NINETAILED_CORE_PLUGIN_NAME,
   SET_ENABLED_FEATURES,
-} from '@ninetailed/experience.js-shared';
+} from '@ninetailed/experience.js';
+import { FEATURES } from '@ninetailed/experience.js-shared';
 import {
   DEFAULT_ACCEPTED_CONSENT_CONFIG,
   DEFAULT_PRIVACY_CONFIG,

packages/plugins/privacy/src/NinetailedPrivacyPlugin.ts

@@ -10,8 +10,8 @@ import {
   CONSENT,
   COMPONENT,
   COMPONENT_START,
-  SET_ENABLED_FEATURES,
   PLUGIN_NAME as NINETAILED_CORE_PLUGIN_NAME,
+  SET_ENABLED_FEATURES,
 } from '@ninetailed/experience.js';
 import wildCardMatch from 'wildcard-match';
 import { isEqual } from 'radash';

packages/sdks/javascript/src/lib/Ninetailed.ts

@@ -75,9 +75,9 @@
   }
 }
 
 type GetItem<T = any> = (key: string) => T;
 
 type SetItem<T = any> = (key: string, value: T) => void;
 
 type RemoveItem = (key: string) => void;
 
@@ -177,6 +177,16 @@
       useSDKEvaluation = false,
     }: Options = {}
   ) {
+    if (typeof onLog === 'function') {
+      logger.addSink(new OnLogLogSink(onLog));
+    }
+
+    if (typeof onError === 'function') {
+      logger.addSink(new OnErrorLogSink(onError));
+    }
+
+    this.logger = logger;
+
     this.useSDKEvaluation = useSDKEvaluation;
 
     if (ninetailedApiClientInstanceOrOptions instanceof NinetailedApiClient) {
@@ -220,17 +230,8 @@
       from: 'api',
     };
 
-    if (typeof onLog === 'function') {
-      logger.addSink(new OnLogLogSink(onLog));
-    }
-
-    if (typeof onError === 'function') {
-      logger.addSink(new OnErrorLogSink(onError));
-    }
-
     this.eventBuilder = new EventBuilder(buildClientContext);
 
-    this.logger = logger;
     this.ninetailedCorePlugin = new NinetailedCorePlugin({
       apiClient: this.apiClient,
       locale,
@@ -480,7 +481,7 @@
 
     if (!(element instanceof Element)) {
       const isObject = typeof element === 'object' && element !== null;
       const constructorName = isObject ? (element as any).constructor.name : '';
       const isConstructorNameNotObject =
         constructorName && constructorName !== 'Object';
 

packages/sdks/javascript/src/lib/NinetailedCorePlugin/NinetailedCorePlugin.ts

@@ -55,14 +55,14 @@
 
 export const PLUGIN_NAME = 'ninetailed:core';
 
 type EventFn = { payload: any; instance: InternalAnalyticsInstance };
 
 type AbortableFnParams = { abort: () => void; payload: unknown };
 
 const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
 
 type InternalAnalyticsInstance = AnalyticsInstance & {
   dispatch: (action: any) => void;
 };
 
 export interface NinetailedCorePlugin extends NinetailedAnalyticsPlugin {
@@ -143,16 +143,13 @@
       }
     }
 
-    instance.on(
-      SET_ENABLED_FEATURES,
-      ({ payload }: { payload: { features: Feature[] } }) => {
-        this.enabledFeatures = payload.features || [];
-      }
-    );
-
     logger.debug('Ninetailed Core plugin initialized.');
   }
 
+  public [SET_ENABLED_FEATURES] = async ({ payload }: EventFn) => {
+    this.enabledFeatures = payload.features || [];
+  };
+
   public pageStart(params: AbortableFnParams) {
     return this.abortNonClientEvents(params);
   }

packages/sdks/javascript/src/lib/NinetailedCorePlugin/constants.ts

@@ -10,6 +10,7 @@ export const PROFILE_CHANGE = 'profile-change';
 export const PROFILE_RESET = 'profile-reset';
 
 export const CONSENT = '__nt-consent__';
-export const SET_ENABLED_FEATURES = 'set-enabled-features';
+
+export const SET_ENABLED_FEATURES = 'setEnabledFeatures';
 
 export const EMPTY_MERGE_ID = 'nt:empty-merge-id';

packages/sdks/shared/src/lib/constants.ts

@@ -10,7 +10,6 @@ export const PROFILE_CHANGE = 'profile-change';
 export const PROFILE_RESET = 'profile-reset';
 
 export const CONSENT = '__nt-consent__';
-export const SET_ENABLED_FEATURES = 'set-enabled-features';
 
 export const EMPTY_MERGE_ID = 'nt:empty-merge-id';