Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default send_timeout value #224

Closed
essen opened this issue Apr 5, 2020 · 1 comment
Closed

Set a default send_timeout value #224

essen opened this issue Apr 5, 2020 · 1 comment
Milestone

Comments

@essen
Copy link
Member

essen commented Apr 5, 2020

Sometimes the client is sending much faster than the server is able to process, and the client gets stuck sending data. Then the server may also get stuck when sending data in responses that the client will not process, for example when HTTP/1.1 pipelining was used. Gun should not lock up in these cases, it should just give up.

The Transport:send return value may also need to be checked in order to speed up dropping the connection.

bjosv added a commit to Nordix/gun that referenced this issue Sep 16, 2020
To get faster reaction times on failing socket-send of echos/requests
we now handle the response from the send call where applicable.

To avoid a larger change in the statemachine a send error triggers an
event and is handled like an remote socket error/close.

Fixes ninenines#227 and touches ninenines#224
bjosv added a commit to Nordix/gun that referenced this issue Sep 17, 2020
To get faster reaction times on failing socket-send of echos/requests
we now handle the response from the send call where applicable.

To avoid a larger change in the statemachine a send error triggers an
event and is handled like an remote socket error/close.

Fixes ninenines#227 and touches ninenines#224
bjosv added a commit to Nordix/gun that referenced this issue Oct 7, 2020
To get faster reaction times on failing socket-send of echos/requests
we now handle the response from the send call where applicable.

To avoid a larger change in the statemachine a send error triggers an
event and is handled like an remote socket error/close.

Fixes ninenines#227 and touches ninenines#224
@essen essen added this to the 2.0 milestone Mar 3, 2022
@essen
Copy link
Member Author

essen commented Nov 21, 2022

Done.

@essen essen closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant