-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network issues #448
Fix network issues #448
Conversation
587c05f
to
a4e71de
Compare
Fix incoming dial failure handling for connection pool behavior. Since the recent update of libp2p, [this change](libp2p/rust-libp2p#2191) introduces state to dial request that can be transmitted in `inject_dial_failure`. So there are a couple of cases where the function is called but we can ignore the error since the connection is still to be completed or is already connected. This fixes #447.
f5f27fd
to
56b0bc9
Compare
Codecov Report
@@ Coverage Diff @@
## albatross #448 +/- ##
=============================================
+ Coverage 29.51% 29.65% +0.13%
=============================================
Files 348 348
Lines 33513 33514 +1
Branches 15355 15356 +1
=============================================
+ Hits 9891 9938 +47
- Misses 15183 15205 +22
+ Partials 8439 8371 -68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's a warning on the network.rs
file because the NonZeroU8
import is no longer needed.
Reduce the number of concurrent dial addresses to 1 in the network, which is also the default hence the code won't set any value to it. This was detected as the cause of several dials being launch when issuing a peer dial and provoking error messages since only one of the dial actions succeed while the other fails with messages reporting incoming connection errors. This fixes #446.
56b0bc9
to
3a329d3
Compare
Reduce the number of concurrent dial addresses to 1 in the network,
which is also the default hence the code won't set any value to it.
This was detected as the cause of several dials being launch when
issuing a peer dial and provoking error messages since only one of
the dial actions succeed while the other fails with messages
reporting incoming connection errors.
This fixes Incoming connection failures when a peer is dialed #446.
Fix incoming dial failure handling for connection pool behavour.
Since the recent update of libp2p, this
change introduces
state to dial request that can be transmitted in
inject_dial_failure
. So there are a couple of cases where thefunction is called but we can ignore the error since the connection
is still to be completed or is already connected.
This fixes Dialing a peer sometime results in an error #447.
Pull request checklist