Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in CI jobs: 'SinkImpl::poll_ready called after error. #1319

Closed
viquezclaudio opened this issue Feb 2, 2023 · 2 comments · Fixed by #1368
Closed

Panic in CI jobs: 'SinkImpl::poll_ready called after error. #1319

viquezclaudio opened this issue Feb 2, 2023 · 2 comments · Fixed by #1368
Assignees

Comments

@viquezclaudio
Copy link
Member

This panic has been observed in some instances of our CI jobs:

4079126152

Full panic trace:

:2023-02-02T22:51:14.38892844Z ERROR panic                | thread 'tokio-runtime-worker' panicked at 'SinkImpl::poll_ready called after error.': /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/quicksink-0.1.2/src/lib.rs:158
./validator2.log:26702:   1: log_panics::Config::install_panic_hook::{{closure}}
./validator2.log:26703:             at /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/log-panics-2.1.0/src/lib.rs:115:29
./validator2.log:26706:      std::panicking::rust_panic_with_hook
./validator2.log:26707:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:692:13
./validator2.log:26708:   3: std::panicking::begin_panic::{{closure}}
./validator2.log:26709:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:608:9
./validator2.log:26712:   5: std::panicking::begin_panic
./validator2.log:26713:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:607:12
./validator2.log:26794:  46: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
./validator2.log:26795:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panic/unwind_safe.rs:271:9
./validator2.log:26796:  47: std::panicking::try::do_call
./validator2.log:26797:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:483:40
./validator2.log:26799:  49: std::panicking::try
./validator2.log:26800:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:447:19
./validator2.log:26801:  50: std::panic::catch_unwind
./validator2.log:26802:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panic.rs:137:14
./validator2.log:26843:  69: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
./validator2.log:26844:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panic/unwind_safe.rs:271:9
./validator2.log:26845:  70: std::panicking::try::do_call
./validator2.log:26846:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:483:40
./validator2.log:26848:  72: std::panicking::try
./validator2.log:26849:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:447:19
./validator2.log:26850:  73: std::panic::catch_unwind
./validator2.log:26851:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panic.rs:137:14
./validator2.log:26874:  85: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
./validator2.log:26875:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panic/unwind_safe.rs:271:9
./validator2.log:26876:  86: std::panicking::try::do_call
./validator2.log:26877:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:483:40
./validator2.log:26879:  88: std::panicking::try
./validator2.log:26880:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:447:19
./validator2.log:26881:  89: std::panic::catch_unwind
./validator2.log:26882:             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panic.rs:137:14
@viquezclaudio
Copy link
Member Author

jsdanielh added a commit that referenced this issue Mar 1, 2023
Update the `yamux` dependency from version 0.10.1 to version 0.10.2
to pull a fix for a call to `SinkImpl::poll_ready` after error as
described in [this rust-libp2p
issue](libp2p/rust-libp2p#2598).

This fixes #1319.
@jsdanielh
Copy link
Member

According to this issue in libp2p we should update yamux to 0.10.2 (and we are at 0.10.1). This is being done in #1368.

@jsdanielh jsdanielh self-assigned this Mar 1, 2023
viquezclaudio pushed a commit that referenced this issue Mar 1, 2023
Update the `yamux` dependency from version 0.10.1 to version 0.10.2
to pull a fix for a call to `SinkImpl::poll_ready` after error as
described in [this rust-libp2p
issue](libp2p/rust-libp2p#2598).

This fixes #1319.
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants