Include BasicAccount and contracts into offline build #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styppo
force-pushed
the
soeren/offline-build-accounts
branch
from
f595c3f
to
de9a9fb
Compare
sisou
force-pushed
the
soeren/offline-build-accounts
branch
from
de9a9fb
to
0191cde
Compare
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=============================
=============================
Continue to review full report at Codecov.
|
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Nov 17, 2020
Swaps require the HTLC account type to be included, which it is currently not in the web-offline build. PR pending to add it is nimiq/core-js#572.
mar-v-in
approved these changes
Feb 11, 2021
sisou
force-pushed
the
soeren/offline-build-accounts
branch
from
0191cde
to
d6049fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 3 account types BasicAccount, VestingContract and HashedTimeLockContract to the offline build, as they are needed to construct and verify transactions for atomic swaps in the Hub.