-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#553] Define BaseScreen composable for all screens #533
Conversation
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
File | Coverage |
---|---|
BaseScreen.kt |
50.77% |
HomeScreen.kt |
65.00% |
Modified Files Not Found In Coverage Report:
ComposableUtil.kt
SecondScreen.kt
ThirdScreen.kt
Versions.kt
build.gradle.kts
colors.xml
styles.xml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
9af6f4c
to
790795a
Compare
8da6706
to
2edce96
Compare
790795a
to
ad26c24
Compare
3890ae3
to
6034a33
Compare
6034a33
to
c5fe65f
Compare
Just one concern. Isn't |
@luongvo Please resolve the conflict 🙏🏼 |
c5fe65f
to
a43d6c0
Compare
@kaungkhantsoe, I think we can keep the current approach. It's a deprecated approach, but I added it to the |
@ryan-conway This one could be processed now. It's also fine if you want to get more reviews from @nimblehq/chapter-android 🏃 |
Closes #553
What happened 👀
BaseScreen
composable for all screens, as we did withBaseActivity
orBaseFragment
.accompanist-systemuicontroller
to demo the status bar color changing between screens.Insight 📝
The
BaseScreen
will contain base parameters to request & base logic in the body to execute for all screens.Proof Of Work 📹
Screen_recording_20231031_180930.mp4