semfold: fix range-check folding #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix literals resulting from folding range-check conversions having a type that doesn't match the node kind. This, in turn, fixes a VM code generator issue where the code generated for an access of the result of an integer-literal-converted-to-float-range would cause the VM to crash. Details ======= The folding logic directly assigned the destination type to the literal, which led to, for example, integer literals having a `tyFloat` type. This breaks the assumption of only float-literal nodes having a float type, and is what caused the `vmgen` bug (`vmgen` only looks at the node kind). Same as for normal conversion, range-check conversion are now also folded via `foldConv` (but only in case the range check succeeds), fixing the issue.
zerbina
added
bug
saem
approved these changes
Jul 31, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix literals resulting from folding range-check conversions having a
type that doesn't match the node kind. This, in turn, fixes a VM code
generator issue where the code generated for an access of the result of
an integer-literal-converted-to-float-range would cause the VM to crash.
Details
The folding logic directly assigned the destination type to the literal,
which led to, for example, integer literals having a
tyFloattype.This breaks the assumption of only float-literal nodes having a float
type, and is what caused the
vmgenbug (vmgenonly looks at the nodekind).
Same as for normal conversion, range-check conversion are now also
folded via
foldConv(but only in case the range check succeeds),fixing the issue.