Specification tests PR2 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
reviewed
Nov 7, 2021
haxscramper
changed the title
saem
reviewed
Nov 8, 2021
saem
reviewed
Nov 9, 2021
|
Please review impacted files from my edits/proofing. |
haxscramper
commented
Nov 9, 2021
saem
requested changes
Nov 11, 2021
alaviss
reviewed
Nov 12, 2021
|
Todo, remove panics flag? |
|
Just had another quick read, it's looking good. A more natural architecture is starting to show up, the organization at the language concept level is helping clarify in my head some of the structuring to be done in the compiler. |
commit 79ab24b Author: haxscramper <[email protected]> Date: Fri Nov 12 14:49:30 2021 +0300 [REVIEW] commit bc9d020 Author: shayanhabibi <[email protected]> Date: Tue Nov 9 16:33:03 2021 +0800 review fixes commit 1dee7e6 Author: shayanhabibi <[email protected]> Date: Tue Nov 9 16:04:36 2021 +0800 'progress' as they say commit 4911131 Author: haxscramper <[email protected]> Date: Mon Nov 8 14:21:41 2021 +0300 [REVIEW] Compiletime test corrections commit 35f52bc Author: haxscramper <[email protected]> Date: Mon Nov 8 13:53:49 2021 +0300 [TEST] All lang specification tests pass locally commit be7ae6d Author: haxscramper <[email protected]> Date: Sun Nov 7 23:38:27 2021 +0300 [DOC] Assorted test edits, mostly enum/arrays commit 1bfc8a5 Author: haxscramper <[email protected]> Date: Sun Nov 7 17:08:45 2021 +0300 [DOC} Language specification tests
haxscramper
force-pushed
the
language-spec-2
branch
from
79ab24b to
f447707
Compare
saem
approved these changes
Nov 13, 2021
|
bors r+ |
|
Build succeeded: |
haxscramper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.