Replace PCtx parameters with TCtx in VM code

[zerbina]

• Where TCtx is now used, also use func instead of proc, if applicable

Not all usages of PCtx are replaced. PCtx is still used in procedures
that form the border between non-VM/VM code. vmops also still uses
PCtx, as some ops need to capture a reference to the context

[saem]

Minor item, the other thing I noticed is that some functions have effects, will need to change those to procs or break them up. I'd go the proc route, personally.

[zerbina]

Addressed review. I used proc again for the functions that fail the strict side-effect test.

I also fixed the failure of the tcompilerapi.nim test. It failed due to PCtx still being used as arguments in nimeval.nim.

Interestingly enough, in the CI, the test failure was reported to be due to the compiler crashing with a nil access. I ran the test on my machine (Windows) and it also failed with a compiler crash. But, instead of an invalid memory access, I got an assertion raised in semcall.nim.

The compiler crash only happened when importing nimeval. Adjusting the PCtx usage made the crash go away too.

[saem]

I did a quick search in finding usage in semdata and semmagic, but those are at the boundary as mentioned by the PR.

[saem]

And so begins the revamp of the VM in devel. 🎉

Bors r+

[bors]

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

[alaviss]

Weird, let's try again

bors r+

[bors]

Build succeeded:

• All check passed
• All reproducibility tests passed