-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up symbol error reporting #1373
Merged
chore-runner
merged 6 commits into
nim-works:devel
from
zerbina:clean-up-erroneous-symbol-handling
Jul 7, 2024
Merged
clean up symbol error reporting #1373
chore-runner
merged 6 commits into
nim-works:devel
from
zerbina:clean-up-erroneous-symbol-handling
Jul 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type or init expression has an error, the symbol itself is not turned into an error.
Instead of it, the silent `adWrappedSymError` is used.
For routine, var, let, and const symbols, no error is reported on usage anymore.
zerbina
added
compiler/sem
Related to semantic-analysis system of the compiler
simplification
Removal of the old, unused, unnecessary or un/under-specified language features.
labels
Jul 7, 2024
saem
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adWrappedSymError
is so much better, really wish this approach occurred to me when I was working on this.
/merge |
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler/sem
Related to semantic-analysis system of the compiler
simplification
Removal of the old, unused, unnecessary or un/under-specified language features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
where the definition has an error
let
/var
/const
symbol where the initializer expression has an errorclutter compiler and nimsuggest output
Details
semSym
skLet
,skVar
, andskConst
intoskError
s when thedefinition AST has an error
adWrappedSymError
diagnostic for erroneous calleesCalleeHasAnError
diagnostic and reporttpointerprocs.nim
, which is affected by the differenterror reporting