remove unnecessary ccgutils
dependency
#1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove an obsolete usage of
ccgIntroducedPtr
from sem, breaking animport dependency between sem and the code generator, and allowing for
ccgIntroducedPtr
to move back toccgtypes
.Details
It was originally possible for the arguments to a copy hook overlapping
in memory (a parameter aliasing violation), resulting in incorrect
behaviour when copying variant objects if they do.
ed12679 worked around this by checking
whether both parameters were (hidden) pointers to the same location,
skipping the copy if they are, with
ccgIntroducedPtr
used to checkwhether the source parameter is passed as via a pointer indirection.
This is a layering violation, and also no longer necessary, since
injecthooks
ensures that the immutable argument doesn't refer to thesame memory location as the mutable one -- the workaround in
liftdestructors
can thus be removed.