mirpasses: implement string COW handling with MIR pass #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerbina
added
refactor
Use a MIR pass to inject the calls to `nimPrepareStrMutationV2`. Same as what `cgen` did, the pass looks for all possible modification of a string's storage and emits a string preparation prior to the modification.
The added MIR pass fully takes care of it, no code generator support is needed.
saem
approved these changes
Apr 27, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perform the injection of runtime procedure calls for handling copy-on-
write strings with an MIR pass, instead of doing it in the C code
generator, removing another responsibility from the latter.
Details
The new MIR pass does the equivalent of what
cgenpreviously did,that is, injecting
nimPrepareStrMutationV2calls wherever a string'sunderlying storage might be modified.
The injection logic, together with the
lfPrepareForMutationflag, isremoved from
cgen.