-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated fix for #280 with dependencies #464
Conversation
I don't see why #280 got linked to these unrelated comments. Regardless, this updated fix has a new issue - if you run I'm thinking we need to keep track of whether before and after hooks have run already or not. I think this can be done by changing PackageInfo.preHook and postHook into Table[string, bool] but it might be overkill. Suggestions appreciated. |
I've fixed this by moving the pre and post execHook() calls within installFromDir(). This ensures that it works correctly whether installing locally or after download. Additionally, I prevent the generic execHook() calls in doAction() from running for actionInstall, similar to actionCustom since they are handled elsewhere. |
Build failed in test for issue #428 - not sure how it is related to this change. |
Relevant issue: https://forum.nim-lang.org/t/3949 (which we should also fix) |
Closing in favour of #482. |
Original fix ran "before install" before dependencies were installed.