Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forge aliases with SAT solver #1296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xTrayambak
Copy link
Contributor

The SAT solver seems to have borked the forge alias logic. This PR fixes it.

@jmgomez
Copy link
Collaborator

jmgomez commented Dec 2, 2024

@xTrayambak thanks. Can you add a test case?

@xTrayambak
Copy link
Contributor Author

@jmgomez Sorry, I'm not quite sure what to write a test-case for here. I've never really worked with the Nimble SAT solver, so I can't do that.

@jmgomez
Copy link
Collaborator

jmgomez commented Dec 2, 2024

@xTrayambak you dont need to test anything specific to SAT, just an integration tests where you run nimble install on a package that uses the pv.name.isForgeAlias code path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants